This repository was archived by the owner on Nov 25, 2025. It is now read-only.
ACP-226: add min delay excess to block and verify #1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update avago
…ava-labs/coreth into ceyonur/acp-226-verify-min-delay-excess
ceyonur
changed the title
alarso16
reviewed
Sep 24, 2025
alarso16
approved these changes
Sep 25, 2025
powerslider
reviewed
Sep 29, 2025
powerslider
reviewed
Sep 29, 2025
powerslider
reviewed
Sep 29, 2025
powerslider
reviewed
Sep 29, 2025
powerslider
approved these changes
Sep 29, 2025
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
michaelkaplan13
approved these changes
Sep 30, 2025
Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
…ava-labs/coreth into ceyonur/acp-226-verify-min-delay-excess
ceyonur
commented
Sep 30, 2025
plugin/evm/customheader/customheadertest/test_min_delay_excess.go
Outdated
Show resolved
Hide resolved
StephenButtolph
approved these changes
Oct 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
It adds calculated min delay excess to the header and verifies it
Closes: #1170
How this works
customheaderpkgconsensus.go/FinalizeAndAssemblewrapped_block.go/semanticVerifyHow this was tested
added uts
Need to be documented?
no
Need to update RELEASES.md?
no